4 comments

  • virtualritz 24 days ago
    Should be checked against official Rust API naming guidelines. LrukCache, not LRUKCache etc.

    https://rust-lang.github.io/api-guidelines/naming.html#casin...

    • yccs27 24 days ago
      Thanks for the link, nice to see the informal conventions spelled out like this!
    • failsafe 24 days ago
      ah, gad damn it. cheers though :P
  • fyrn_ 24 days ago
    Would love to see benchmarks vs competition considering the high performance claim. Foyer is another rust hybrid cache, and quick-cache is the fastest in-memory impl I'm aware of.

    Sane defaults and easy of setting a memory limit are two other things I look for in caches.

  • carlmr 24 days ago
    On your example, without reading into the implementation, I'm wondering if the comment is wrong, or if the comment is telling us about a hidden default, but then what does the 2 mean.

        // Create an LRU cache with a capacity of 100 entries
        let mut cache = LRUKCache::new(2);
    
    
    Why 100? Why not 2?
    • touisteur 24 days ago
      Another time I wish rust had named parameters. For reading code without an IDE (which is a lot of the experience in discovering a library, learning, navigating in code on github...) it would be useful.
      • carlmr 23 days ago
        I think so, too, it's beautifully designed in many ways, but this seems like an oversight.
    • failsafe 24 days ago
      derp, It should be LRU instead of LRU-K.