2 comments

  • elffjs 16 minutes ago
    Something from the PR description that I had to look up to understand: "WTF" is "WebKit Template Framework".
  • saagarjha 1 hour ago
    I feel like https://github.com/oven-sh/WebKit/commit/35315978baee84ed1bd... is the more interesting commit tbh
    • jasdfwasd 35 minutes ago
      > p = (char*)"";

      yikes

      • lioeters 16 minutes ago
        I thought that was a typo or the forum software removed something, but no - it's a pointer to an empty string literal. If I understand how that works, this creates a null byte (in the read-only memory section of the compiled output?) and points to it. Before this line it checks if p is NULL.

        I wonder what is the advantage of doing this? Maybe to make sure that p is an actual pointer, so later code can just make that assumption.